kmix patch

Hugo Pereira Da Costa hugo at
Wed Jun 23 18:05:32 BST 2010


About a week ago I suggested a patch that address bug 220621 (a crash in kmix) 
(see I'd rather post it on kde 
reviewboard for reviewing, but could not find a relevant group for this. 

Since there's been no comment on this in the bugzilla page, I post it again 
here, attached.
The patch addresses the following issue: 

"_dockAreaPopup->deleteLater()" in  KMixWindow::updateDocking(), leaves the 
"parent" QWidgetAction with a dangling pointer to the widget,
until the action is actually re-created, later on in the code. 

The patch stores and deletes the QWidgetAction directly,
which in turn deletes the widget and has the advantage of not 
leaving any dangling pointer behind, thus preventing (notably) the crash above
triggered by oxygen. 

Comments/advice are welcome.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kmix.patch
Type: text/x-patch
Size: 2219 bytes
Desc: not available
URL: <>

More information about the kde-core-devel mailing list