Review Request: Export some of the previously hidden symbols in Solid::Networking and Solid::PowerManagement

[Arno Rehn]

> On 2010-06-15 20:22:46, Kevin Ottens wrote:
> > /trunk/KDE/kdelibs/solid/solid/networking.h, line 121
> > <http://reviewboard.kde.org/r/4324/diff/1/?file=28748#file28748line121>
> >
> >     Why not private?

The actual implementation is a subclass of the Notifier class and in the networking_p.h header. Changing access to private would break compilation.


> On 2010-06-15 20:22:46, Kevin Ottens wrote:
> > /trunk/KDE/kdelibs/solid/solid/powermanagement.h, line 112
> > <http://reviewboard.kde.org/r/4324/diff/1/?file=28749#file28749line112>
> >
> >     Why not private?

Same here: Actual implementation is in a subclass of Notifier.


- Arno


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4324/#review6125
-----------------------------------------------------------


On 2010-06-15 20:35:23, Arno Rehn wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4324/
> -----------------------------------------------------------
> 
> (Updated 2010-06-15 20:35:23)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> This patch will export some of the previously hidden symbols. This is required for the Solid language bindings to come out pretty, because they partly rely on Qt's meta-object system for signal introspection.
> 
> Changing the constructor access for the Notifier classes to 'protected' would normally be source incompatible. But the symbol was previously hidden, so no app could have linked against it anyway.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/solid/solid/networking.h 1137325 
>   /trunk/KDE/kdelibs/solid/solid/networking.cpp 1137325 
>   /trunk/KDE/kdelibs/solid/solid/powermanagement.h 1137325 
>   /trunk/KDE/kdelibs/solid/solid/powermanagement.cpp 1137325 
> 
> Diff: http://reviewboard.kde.org/r/4324/diff
> 
> 
> Testing
> -------
> 
> Compiles fine, bindings generation now works as expected.
> 
> 
> Thanks,
> 
> Arno
> 
>