Review Request: Export some of the previously hidden symbols in Solid::Networking and Solid::PowerManagement

Arno Rehn kde at
Tue Jun 15 21:35:24 BST 2010

This is an automatically generated e-mail. To reply, visit:

(Updated 2010-06-15 20:35:23.939746)

Review request for kdelibs.


Put the implementation of the constructors into the cpp file.


This patch will export some of the previously hidden symbols. This is required for the Solid language bindings to come out pretty, because they partly rely on Qt's meta-object system for signal introspection.

Changing the constructor access for the Notifier classes to 'protected' would normally be source incompatible. But the symbol was previously hidden, so no app could have linked against it anyway.

Diffs (updated)

  /trunk/KDE/kdelibs/solid/solid/networking.h 1137325 
  /trunk/KDE/kdelibs/solid/solid/networking.cpp 1137325 
  /trunk/KDE/kdelibs/solid/solid/powermanagement.h 1137325 
  /trunk/KDE/kdelibs/solid/solid/powermanagement.cpp 1137325 



Compiles fine, bindings generation now works as expected.



More information about the kde-core-devel mailing list