Review Request: Export some of the previously hidden symbols in Solid::Networking and Solid::PowerManagement

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4324/#review6125
-----------------------------------------------------------


I expected this one to be a no-brainer and trivial. It turns out it raises interesting questions. Could you please address the following comments? I'll try to summon Will on this patch for the parts I'm unsure of in networking.h

/me starts his dance and trance.


/trunk/KDE/kdelibs/solid/solid/networking.h
<http://reviewboard.kde.org/r/4324/#comment5725>

    I'd like to have Will's opinion on this one, and the following policy ones.
    
    Just to make sure it wasn't intentional, as I don't quite remember if he considered this as stable interface.



/trunk/KDE/kdelibs/solid/solid/networking.h
<http://reviewboard.kde.org/r/4324/#comment5728>

    Why not private?



/trunk/KDE/kdelibs/solid/solid/networking.h
<http://reviewboard.kde.org/r/4324/#comment5724>

    Please put the implementation part of the ctor in the cpp file.
    



/trunk/KDE/kdelibs/solid/solid/powermanagement.h
<http://reviewboard.kde.org/r/4324/#comment5727>

    Why not private?



/trunk/KDE/kdelibs/solid/solid/powermanagement.h
<http://reviewboard.kde.org/r/4324/#comment5726>

    Same, please put the implementation in the cpp file.


- Kevin


On 2010-06-15 14:45:55, Arno Rehn wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4324/
> -----------------------------------------------------------
> 
> (Updated 2010-06-15 14:45:55)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> This patch will export some of the previously hidden symbols. This is required for the Solid language bindings to come out pretty, because they partly rely on Qt's meta-object system for signal introspection.
> 
> Changing the constructor access for the Notifier classes to 'protected' would normally be source incompatible. But the symbol was previously hidden, so no app could have linked against it anyway.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/solid/solid/networking.h 1137325 
>   /trunk/KDE/kdelibs/solid/solid/powermanagement.h 1137325 
> 
> Diff: http://reviewboard.kde.org/r/4324/diff
> 
> 
> Testing
> -------
> 
> Compiles fine, bindings generation now works as expected.
> 
> 
> Thanks,
> 
> Arno
> 
>