Review Request: Export some of the previously hidden symbols in Solid::Networking and Solid::PowerManagement

Arno Rehn kde at arnorehn.de
Tue Jun 15 15:45:55 BST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4324/
-----------------------------------------------------------

Review request for kdelibs.


Summary
-------

This patch will export some of the previously hidden symbols. This is required for the Solid language bindings to come out pretty, because they partly rely on Qt's meta-object system for signal introspection.

Changing the constructor access for the Notifier classes to 'protected' would normally be source incompatible. But the symbol was previously hidden, so no app could have linked against it anyway.


Diffs
-----

  /trunk/KDE/kdelibs/solid/solid/networking.h 1137325 
  /trunk/KDE/kdelibs/solid/solid/powermanagement.h 1137325 

Diff: http://reviewboard.kde.org/r/4324/diff


Testing
-------

Compiles fine, bindings generation now works as expected.


Thanks,

Arno





More information about the kde-core-devel mailing list