Review Request: KFileMetaDataWidget: Provide signal when the request for meta data has been finished

[Michael Pyne]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4777/#review6752
-----------------------------------------------------------


Adding a new signal is hardly an invasive change, even for a bugfix release. I'm aware of no prohibitions regarding that, it is certainly still source and binary compatible.

With that said, you should add appropriate @since documentation for the signal if it gets added. Also be sure to emit the signal everywhere it is required (I'm not saying that you haven't, only that I haven't double-checked).

Only reason I don't click Ship It is to allow dfaure to chime in. :)

- Michael


On 2010-07-29 15:27:58, Peter Penz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4777/
> -----------------------------------------------------------
> 
> (Updated 2010-07-29 15:27:58)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Summary
> -------
> 
> To be able to fix bug https://bugs.kde.org/show_bug.cgi?id=245491 in a clean way for KDE SC 4.5.1, I'd need to introduce a new signal to the class KFileMetaDataWidget (see [1]).
> 
> - Is it allowed to introduce a new signal to a bugfix release, if this is required to fix a bug?
> - Should I add a @since KDE SC 4.5.1 tag to the documentation? (a related fix in Dolphin that uses this signal would be committed later in this case)
> 
> 
> [1] KFileMetaDataWidget requests the meta data for KFileItems asynchronously. Usually applications don't need to care about this, but in the case if this widget is shown inside a tooltip, it is an important detail. This is because the tooltip should not be resized after it has been opened already. Resizing a tooltip if it is already open gets especially a problem on the right/bottom corners (-> clipping, repositioning, take care not to overlap the mouse pointer...) With this signal it is possible to postpone the opening of the tooltip, until the information has been received.
> 
> 
> This addresses bug 245491.
>     https://bugs.kde.org/show_bug.cgi?id=245491
> 
> 
> Diffs
> -----
> 
>   /branches/KDE/4.5/kdelibs/kio/kfile/kfilemetadatawidget.h 1156711 
>   /branches/KDE/4.5/kdelibs/kio/kfile/kfilemetadatawidget.cpp 1156711 
> 
> Diff: http://reviewboard.kde.org/r/4777/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Peter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100730/909b0931/attachment.htm>