<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4777/">http://reviewboard.kde.org/r/4777/</a>
</td>
</tr>
</table>
<br />
<pre>Adding a new signal is hardly an invasive change, even for a bugfix release. I'm aware of no prohibitions regarding that, it is certainly still source and binary compatible.
With that said, you should add appropriate @since documentation for the signal if it gets added. Also be sure to emit the signal everywhere it is required (I'm not saying that you haven't, only that I haven't double-checked).
Only reason I don't click Ship It is to allow dfaure to chime in. :)</pre>
<br />
<p>- Michael</p>
<br />
<p>On July 29th, 2010, 3:27 p.m., Peter Penz wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs and David Faure.</div>
<div>By Peter Penz.</div>
<p style="color: grey;"><i>Updated 2010-07-29 15:27:58</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">To be able to fix bug https://bugs.kde.org/show_bug.cgi?id=245491 in a clean way for KDE SC 4.5.1, I'd need to introduce a new signal to the class KFileMetaDataWidget (see [1]).
- Is it allowed to introduce a new signal to a bugfix release, if this is required to fix a bug?
- Should I add a @since KDE SC 4.5.1 tag to the documentation? (a related fix in Dolphin that uses this signal would be committed later in this case)
[1] KFileMetaDataWidget requests the meta data for KFileItems asynchronously. Usually applications don't need to care about this, but in the case if this widget is shown inside a tooltip, it is an important detail. This is because the tooltip should not be resized after it has been opened already. Resizing a tooltip if it is already open gets especially a problem on the right/bottom corners (-> clipping, repositioning, take care not to overlap the mouse pointer...) With this signal it is possible to postpone the opening of the tooltip, until the information has been received.
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=245491">245491</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/KDE/4.5/kdelibs/kio/kfile/kfilemetadatawidget.h <span style="color: grey">(1156711)</span></li>
<li>/branches/KDE/4.5/kdelibs/kio/kfile/kfilemetadatawidget.cpp <span style="color: grey">(1156711)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4777/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>