Review Request: Don't spell check single characters of the form '<', '=', etc., and 'words' composed of numbers only.
David Faure
faure at kde.org
Thu Jul 22 09:22:53 BST 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4697/#review6661
-----------------------------------------------------------
Ship it!
Looks good. Just one comment.
/branches/KDE/4.5/kdelibs/kdecore/sonnet/filter.cpp
<http://reviewboard.kde.org/r/4697/#comment6428>
Hmm, where are newStart and newStr defined? (in other words does this kDebug statement still compile if the #if 0 is turned into a #if 1?)
- David
On 2010-07-20 16:58:18, Michel Ludwig wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4697/
> -----------------------------------------------------------
>
> (Updated 2010-07-20 16:58:18)
>
>
> Review request for kdelibs.
>
>
> Summary
> -------
>
> Don't spell check single characters of the form '<', '=', etc., and 'words' composed of numbers only.
>
> Back-port from trunk.
>
>
> Diffs
> -----
>
> /branches/KDE/4.5/kdelibs/kdecore/sonnet/filter.cpp 1152275
>
> Diff: http://reviewboard.kde.org/r/4697/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100722/ead3bc67/attachment.htm>
More information about the kde-core-devel
mailing list