<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4697/">http://reviewboard.kde.org/r/4697/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre>Looks good. Just one comment.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="/r/4697/diff/1/?file=31538#file31538line132" style="color: black; font-weight: bold; text-decoration: underline;">/branches/KDE/4.5/kdelibs/kdecore/sonnet/filter.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: break-word;">finderNextWord(QTextBoundaryFinder &finder, QString &word, int &bufferStart)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">119</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: break-word;"><span class="c"> <span class="hl">q</span>Debug()<< "Word at " << <span class="hl">s</span>tart<< " word = <span class="hl">'</span>"</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">132</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: break-word;"><span class="c"> <span class="hl">k</span>Debug() << "Word at " << <span class="hl">newS</span>tart << " word = "</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em">Hmm, where are newStart and newStr defined? (in other words does this kDebug statement still compile if the #if 0 is turned into a #if 1?)</pre>
</div>
<br />
<p>- David</p>
<br />
<p>On July 20th, 2010, 4:58 p.m., Michel Ludwig wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Michel Ludwig.</div>
<p style="color: grey;"><i>Updated 2010-07-20 16:58:18</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">Don't spell check single characters of the form '<', '=', etc., and 'words' composed of numbers only.
Back-port from trunk.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/KDE/4.5/kdelibs/kdecore/sonnet/filter.cpp <span style="color: grey">(1152275)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4697/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>