Review Request: document KUniqueApplication::loadCommandLineOptionsForNewInstance and implement stub

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4278/#review6493
-----------------------------------------------------------

Ship it!


I'm ok with this being documented (but not with a "virtual" comment; declaring it just virtual in the app won't work, it has to be declared a slot), and with the patch to fix the runtime warning.

- David


On 2010-06-12 06:00:15, argonel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4278/
> -----------------------------------------------------------
> 
> (Updated 2010-06-12 06:00:15)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Adds a stub version of loadCommandLineOptionsForNewInstance to squelch the new warning in QT4.7.
> 
> 
> This addresses bug 241435.
>     https://bugs.kde.org/show_bug.cgi?id=241435
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/kdeui/kernel/kuniqueapplication.h 1128365 
>   trunk/KDE/kdelibs/kdeui/kernel/kuniqueapplication.cpp 1128365 
> 
> Diff: http://reviewboard.kde.org/r/4278/diff
> 
> 
> Testing
> -------
> 
> Doxygen doesn't produce output yet, I'll get to the bottom of that eventually.
> 
> 
> Thanks,
> 
> argonel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100712/082742ed/attachment.htm>