Review Request: Allow Middle click paste onto page does not use default web shortcut (bug# 243942)

Dawit Alemayehu adawit at kde.org
Sat Jul 10 07:37:45 BST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4578/
-----------------------------------------------------------

Review request for kdelibs.


Summary
-------

The attached patch addresses the issue reported by the bug # given above. The changes make the following possible with the the code that handles MMB paste of clipboard content:

#1. If the pasted content is not a valid URL, use the default search engine, if configured, to search for the pasted content.
#2. Properly handle cases where the clipboard's content would not be considered valid URL, e.g. "www.kde.org".
#3. Limit the amount of text we process to 256 as a precaution.


This addresses bug 243942.
    https://bugs.kde.org/show_bug.cgi?id=243942


Diffs
-----

  branches/KDE/4.5/kdelibs/kdewebkit/kwebview_p.h 1148199 

Diff: http://reviewboard.kde.org/r/4578/diff


Testing
-------


Thanks,

Dawit

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100710/03655bde/attachment.htm>


More information about the kde-core-devel mailing list