Review Request: Unquoted/unescaped directory name passed to "cd" command in dolphin embedded terminal

Oswald Buddenhagen ossi at kde.org
Wed Jan 27 23:38:45 GMT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2703/#review3922
-----------------------------------------------------------

Ship it!



/trunk/KDE/kdelibs/kdecore/util/kshell_unix.cpp
<http://reviewboard.kde.org/r/2703/#comment3309>

    a ghost from an amok running vim script, i was told ... :D


- Oswald


On 2010-01-27 23:35:31, Nicolas L├ęcureuil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2703/
> -----------------------------------------------------------
> 
> (Updated 2010-01-27 23:35:31)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> This patch add !~[] as special letters to be escaped, this fix the use of the embeded terminal
> 
> 
> This addresses bug 220092.
>     https://bugs.kde.org/show_bug.cgi?id=220092
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdecore/util/kshell_unix.cpp 1081034 
> 
> Diff: http://reviewboard.kde.org/r/2703/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nicolas
> 
>





More information about the kde-core-devel mailing list