Review Request: kio-file: sync file copy to /media/

[Lubos Lunak]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2690/#review3869
-----------------------------------------------------------


I disagree with the patch. Code that does copying should simply copy it. It is the responsibility of whatever mounted the device to mount it properly. The patch is just a kludge and I don't see why we should intentionally make things worse for everybody just because somebody doesn't know how to use a removable device.

- Lubos


On 2010-01-23 14:23:52, Davide Bettio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2690/
> -----------------------------------------------------------
> 
> (Updated 2010-01-23 14:23:52)
> 
> 
> Review request for kdelibs, Kevin Ottens and David Faure.
> 
> 
> Summary
> -------
> 
> This simple patch allows file copy to external devices to be synchronous. This patch assumes that external devices are mounted on a subdirectory of /media/. If /media/ is not used this patch will not work so everything will be as before.
> For more dettails see also https://bugs.kde.org/show_bug.cgi?id=195044.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kioslave/file/file_unix.cpp 1077183 
> 
> Diff: http://reviewboard.kde.org/r/2690/diff
> 
> 
> Testing
> -------
> 
> This patch is recent, so I'm testing it right now. kio-file is a critical component so I will do more tests.
> 
> Checking for file corruption might be a good idea:
> dd if=/dev/full of=testFile count=numOfBlocks
> md5sum testFile
> Copy it, umount, mount and check the md5sum.
> 
> 
> Thanks,
> 
> Davide
> 
>