Review Request: Move KNewMenu from libkonq to kdelibs.

[Aaron Seigo]

> On 2010-01-15 22:45:40, Aaron Seigo wrote:
> > /trunk/KDE/kdelibs/kfile/knewfilemenu.h, line 128
> > <http://reviewboard.kde.org/r/2629/diff/1/?file=17173#file17173line128>
> >
> >     should slot be remove from its name? perhaps jobResult(KJob *job)?
> 
> David Faure wrote:
>     Hmm. Many virtual slots in KIO jobs are called slotResult, and more importantly, if I rename this one, I'm in trouble in the libkonq kept-for-BC subclass of KNewFileMenu.

thanks for the replies; it sounds reasonable to me .. looking forward to seeing this in kdelibs :)


- Aaron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2629/#review3717
-----------------------------------------------------------


On 2010-01-15 21:09:00, David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2629/
> -----------------------------------------------------------
> 
> (Updated 2010-01-15 21:09:00)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Move KNewMenu from libkonq to kdelibs/kfile, so that http://reviewboard.kde.org/r/2535/ can use it (in order to add "RMB / New File" in kdiroperator, which benefits KFileDialog and other users of kdiroperator).
> 
> Since libkonq is public API, the "moving" needs a renaming (and the existing classes will use the moved ones), so the new class name is KNewFileMenu. The dialog for entering name+url is moved too, as KNameAndUrlInputDialog [should this go to libkio instead? better decide now or we'll need to change the name again].
> 
> The good thing is that this gets rid of some code duplication for creating directories: the libkonq code moving to libkfile means that KDirOperator::mkdir can now use it, rather than its own fork of it. Done in this patch, so as a side effect this patch actually adds RMB / Create New in kdiroperator - taken from 2535 :) I'll let Abhishek finish it though (adding the support for "only showing the mimetypes that are relevant to the current application").
> 
> 
> This addresses bug 93230.
>     https://bugs.kde.org/show_bug.cgi?id=93230
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kfile/CMakeLists.txt 1071368 
>   /trunk/KDE/kdelibs/kfile/kdiroperator.h 1071368 
>   /trunk/KDE/kdelibs/kfile/kdiroperator.cpp 1071368 
>   /trunk/KDE/kdelibs/kfile/knameandurlinputdialog.h PRE-CREATION 
>   /trunk/KDE/kdelibs/kfile/knameandurlinputdialog.cpp PRE-CREATION 
>   /trunk/KDE/kdelibs/kfile/knewfilemenu.h PRE-CREATION 
>   /trunk/KDE/kdelibs/kfile/knewfilemenu.cpp PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/2629/diff
> 
> 
> Testing
> -------
> 
> RMB / Create New in KFileDialog. Creating a dir still enters it like it did before.
> 
> 
> Thanks,
> 
> David
> 
>