Review Request: KTabBar/KTabWidget: Fix MMB tab moving regression, add unit test, clarify API docs

Frank Reininghaus frank78ac at
Fri Jan 15 23:32:12 GMT 2010

This is an automatically generated e-mail. To reply, visit:

Review request for kdelibs.


This patch fixes a recent regression that broke the traditional MMB tab moving (used, e.g., in Konqueror). It also adds a unit test, un-deprecates KTabBar's moveTab(int,int) signal and clarifies the API docs:

1. The signal KTabBar::moveTab(int,int) is not equivalent to QTabBar::tabMoved(int,int).
2. Qt's tab moving mechanism (which is there since Qt 4.5) is not totally equivalent to KDE's tradition MMB tab moving (e.g., it breaks drag&drop to other applications) -> KTabBar::setTabReorderingEnabled(true) can in general not be replaced safely by QTabBar::setMovable(true).

This addresses bug 214646.


  /branches/KDE/4.4/kdelibs/kdeui/tests/ktabwidget_unittest.cpp 1075319 
  /branches/KDE/4.4/kdelibs/kdeui/widgets/ktabbar.h 1075319 
  /branches/KDE/4.4/kdelibs/kdeui/widgets/ktabwidget.cpp 1075319 



MMB tab moving works again in Konqueror, new unit test (which failed before the change in ktabwidget.cpp) passes.



More information about the kde-core-devel mailing list