Review Request: fix compile error in xsyncbasedpoller

Tom Albers toma at kde.org
Sun Jan 17 14:59:37 GMT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2641/#review3737
-----------------------------------------------------------

Ship it!


I changed it yesterday because the overflow was a uint. Strange. Can you add a comment about it so it does not get changed again?

- Tom


On 2010-01-17 14:53:32, Milian Wolff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2641/
> -----------------------------------------------------------
> 
> (Updated 2010-01-17 14:53:32)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Fix compilation error on my machine (gcc (GCC) 4.4.2 20091208 (prerelease)), probably some unclear compiler behavior or a new strictness in GCC?
> 
> /home/kde4trunk/projects/kde4/kdelibs/kutils/kidletime/xsyncbasedpoller.cpp: In member function 'virtual void XSyncBasedPoller::catchIdleEvent()':
> /home/kde4trunk/projects/kde4/kdelibs/kutils/kidletime/xsyncbasedpoller.cpp:242: error: invalid conversion from 'uint*' to 'int*'
> /home/kde4trunk/projects/kde4/kdelibs/kutils/kidletime/xsyncbasedpoller.cpp:242: error:   initializing argument 4 of 'void XSyncValueAdd(XSyncValue*, XSyncValue, XSyncValue, int*)'
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kutils/kidletime/xsyncbasedpoller.cpp 1075898 
> 
> Diff: http://reviewboard.kde.org/r/2641/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Milian
> 
>





More information about the kde-core-devel mailing list