Review Request: Move KNewMenu from libkonq to kdelibs.

David Faure faure at
Fri Jan 15 21:09:01 GMT 2010

This is an automatically generated e-mail. To reply, visit:

Review request for kdelibs.


Move KNewMenu from libkonq to kdelibs/kfile, so that can use it (in order to add "RMB / New File" in kdiroperator, which benefits KFileDialog and other users of kdiroperator).

Since libkonq is public API, the "moving" needs a renaming (and the existing classes will use the moved ones), so the new class name is KNewFileMenu. The dialog for entering name+url is moved too, as KNameAndUrlInputDialog [should this go to libkio instead? better decide now or we'll need to change the name again].

The good thing is that this gets rid of some code duplication for creating directories: the libkonq code moving to libkfile means that KDirOperator::mkdir can now use it, rather than its own fork of it. Done in this patch, so as a side effect this patch actually adds RMB / Create New in kdiroperator - taken from 2535 :) I'll let Abhishek finish it though (adding the support for "only showing the mimetypes that are relevant to the current application").

This addresses bug 93230.


  /trunk/KDE/kdelibs/kfile/CMakeLists.txt 1071368 
  /trunk/KDE/kdelibs/kfile/kdiroperator.h 1071368 
  /trunk/KDE/kdelibs/kfile/kdiroperator.cpp 1071368 
  /trunk/KDE/kdelibs/kfile/knameandurlinputdialog.h PRE-CREATION 
  /trunk/KDE/kdelibs/kfile/knameandurlinputdialog.cpp PRE-CREATION 
  /trunk/KDE/kdelibs/kfile/knewfilemenu.h PRE-CREATION 
  /trunk/KDE/kdelibs/kfile/knewfilemenu.cpp PRE-CREATION 



RMB / Create New in KFileDialog. Creating a dir still enters it like it did before.



More information about the kde-core-devel mailing list