[PATCH] New image loader (Softimage PIC)

Ruben Lopez r.lopez at bren.es
Wed Jan 13 15:23:19 GMT 2010

Sebastian Kügler wrote:
> On Monday 11 January 2010 11:54:04 Ruben Lopez wrote:
>> Sebastian Kügler wrote:
>>> On Monday 11 January 2010 11:08:45 Ruben Lopez wrote:
>>>> I have checked the svn repository of kdelibs today, and this patch was
>>>> not included yet. Is there anything else that I should adapt in the
>>>> source code in order to have it included? Should I submit the patch to
>>>> some tracking system?
>>> Usually, people submit the patch themselves to SVN after the review. If
>>> you don't have an SVN account, it's a good idea to indicate that and
>>> have someone else submit it for you. I assume in this case, nobody
>>> understood that, and patches don't get submitted automatically. :)
>> Sorry for generating confussion. Actually, I don't have an SVN account,
>> and I don't think that it is worth to apply for one, as this is a very
>> little contribution and doesn't seem to need much maintenance in the
>> future...
>> Can anyone (you, perhaps?) submit this patch for me?
> Pino said the patch would first need whitespace cleanup, now I haven't looked at it 
> in detail, but I don't have time right now to clean up patches. Can you have a look? 
> (coding style guidelines on techbase.kde.org apply).
> I can commit the patch then.

Attached you will find the new patch with whitespaces (and brackets) 
following the techbase.kde.org guidelines. I assumed that the following 
were the right ones:

I had to use netbeans to clean the code, because kdevelop 3.5.4 doesn't 
follow the KDE guidelines by default, and changing the format properties 
doesn't affect the automatic formatting tool :(

Please, understand that we are a company with our own coding style 
policies and deadlines. We really want to contribute with the 
open-source community as much as possible, but having so many 
restrictions to the contributed code makes it very expensive for us to 
keep up with these contributions.

I wish that this time the code is ready to enter kdelibs. Would you 
submit this patch to svn, please?

Thanks in advance

-------------- next part --------------
A non-text attachment was scrubbed...
Name: kdelibs-4.3.4-bren3.patch
Type: text/x-patch
Size: 30085 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100113/01db50c3/attachment.bin>

More information about the kde-core-devel mailing list