Review Request: Pathch for wish : no way to add a file by rightclicking to a folder, bug 93230

[Christoph Feck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2535/#review3633
-----------------------------------------------------------


Good, that was what I ment when I said to use the KNewMenu inside the context menu.

Regarding the API my idea was as follows:

1) It isn't useful in Kate to create a "Spreadsheet Document", because Kate cannot handle that file type. It would would only make sense for plain text files and HTML files maybe.

2) When the KDirOperator is used in e.g. KFileDialog to save a file, it does not make sense to have the "Create New File" menu item at all.

3) In power applications, such as a Krusader type file manager, it would make sense to allow any file type.

As you see, it would be good to have some API to specify which file types/MIME types/templates the application allows (defaulting to none). Maybe it would make sense to not to use KNewMenu directly, but allow the application to hook in any action or menu, your patch would ask for the filename, make sure it isn't already present, fill the file with template data, and emit a signal that a new file has been created.

Surely something that has to be discussed.

- Christoph


On 2010-01-10 12:32:43, Abhishek Patil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2535/
> -----------------------------------------------------------
> 
> (Updated 2010-01-10 12:32:43)
> 
> 
> Review request for Kate and kdelibs.
> 
> 
> Summary
> -------
> 
> Right click in filesystem browser you will find new option called "New File..." which will create a new Empty file at given location.
> 
> 
> This addresses bug 93230.
>     https://bugs.kde.org/show_bug.cgi?id=93230
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kfile/CMakeLists.txt 1071974 
>   /trunk/KDE/kdelibs/kfile/kdiroperator.cpp 1071974 
> 
> Diff: http://reviewboard.kde.org/r/2535/diff
> 
> 
> Testing
> -------
> 
> Tested on Trunk Revision: 1071973
> 
> 
> Screenshots
> -----------
> 
> Context Menu New
>   http://reviewboard.kde.org/r/2535/s/294/
> 
> 
> Thanks,
> 
> Abhishek
> 
>