Review Request: Pathch for wish : no way to add a file by rightclicking to a folder, bug 93230

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2535/#review3613
-----------------------------------------------------------


other than the stuff below it looks good to me, albeit I'm no kfile developer...


/trunk/KDE/kdelibs/kfile/kdiroperator.h
<http://reviewboard.kde.org/r/2535/#comment2941>

    note that this should become virtual in KDE 5, i.e.:
    
    //TODO KDE5: make virtual



/trunk/KDE/kdelibs/kfile/kdiroperator.h
<http://reviewboard.kde.org/r/2535/#comment2942>

    also add the note here



/trunk/KDE/kdelibs/kfile/kdiroperator.cpp
<http://reviewboard.kde.org/r/2535/#comment2945>

    why not use the same code you have in mkfs(QString), i.e. the KIO::NetAccess::exists check? No need to do that only on the local files, or?



/trunk/KDE/kdelibs/kfile/kdiroperator.cpp
<http://reviewboard.kde.org/r/2535/#comment2944>

    I personally would like to see the validation be moved to the mkfs(QString) method (imo), esp. since it also does some validation and error handling. dunno if that's practicable, maybe by returning a bool from the mkfs(QString). would be good anyways I think



/trunk/KDE/kdelibs/kfile/kdiroperator.cpp
<http://reviewboard.kde.org/r/2535/#comment2946>

    make this "if (!exists) {", i.e. add spaces



/trunk/KDE/kdelibs/kfile/kdiroperator.cpp
<http://reviewboard.kde.org/r/2535/#comment2947>

    spaces here and below as well


- Milian


On 2010-01-09 16:44:59, Abhishek Patil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2535/
> -----------------------------------------------------------
> 
> (Updated 2010-01-09 16:44:59)
> 
> 
> Review request for Kate and kdelibs.
> 
> 
> Summary
> -------
> 
> Right click in filesystem browser you will find new option called "New File..." which will create a new Empty file at given location.
> 
> 
> This addresses bug 93230.
>     https://bugs.kde.org/show_bug.cgi?id=93230
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kfile/kdiroperator.h 1071974 
>   /trunk/KDE/kdelibs/kfile/kdiroperator.cpp 1071974 
> 
> Diff: http://reviewboard.kde.org/r/2535/diff
> 
> 
> Testing
> -------
> 
> Tested on Trunk Revision: 1071973
> 
> 
> Thanks,
> 
> Abhishek
> 
>