Review Request: only query the dns when requesting something from a site not in khtml dns cache.

[Germain Garand]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2463/#review3577
-----------------------------------------------------------


DNS Prefetch is bounded and paced in many ways so as not to be a resource hog. The maximum load it may add for a page is 42 requests spread on 8.4 seconds,
assuming all names are different and uncached yet. I don't believe this is a problem.

the real issue as described in the referred bug report (at comment #14 - the rest is unrelated and most probably solved already by KIO's dns cache)
is not the feature per se, but that the limits are per page and not per process.

it could be solved by keeping track of the total number of queued DNS requests per process instead,
and limiting that to some reasonable value (twice the per page limit?) e.g. maintaining a class static counter in KHTMLPartPrivate.

- Germain


On 2009-12-30 11:28:31, Jaime Torres wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2463/
> -----------------------------------------------------------
> 
> (Updated 2009-12-30 11:28:31)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> With the DNSPrefetch enabled, khtml is quering the dns for each <a href="..."> in every page rendered (if it is not in its nds cache).
> Fortunately, it is not scanning for virus :-) .
> With the DNSPrefetch disabled, khtml will query the dns only when requesting something from a site not in its dns cache.
> 
> 
> This addresses bug 135230.
>     https://bugs.kde.org/show_bug.cgi?id=135230
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/khtml/khtml_settings.cpp 1066188 
> 
> Diff: http://reviewboard.kde.org/r/2463/diff
> 
> 
> Testing
> -------
> 
> See latest bug comments.
> 
> 
> Thanks,
> 
> Jaime
> 
>