[PATCH] devicenotifier and dolphin interactive problem

[Kevin Ottens]

On Monday 28 December 2009 08:45:56 sonald wrote:
> Hi, all
>      I found a problem concerning devicenotifier and dolphin. the
> scenario is quite easy to produce,
> when you plug in a flash drive, devicenotifier applet popup and you
> click it and open with file
> manager ( dolphin ),  it shows mounted state in dolphin. then you click
> devicenotifier to unmount
> it. now dolphin keeps the view of dity content. I believe the problem is
> that no device change event
> reports, so dolphin has no idea how to do this nicely.
>      In the middle of my fix, I found another related problem of
> dolphin. it's also quite easy to show .
> You just click flash drive icon on the places panel in dolphin to mount
> it, and right-click and choose
> 'safely remove' to eject it, then click it again. At this time, no mount
> activated any more.
> 
> I made some changes to kdelibs/kfile and then dolphin to make it all
> work. Is it ok to commit, or any suggestions ?

First a general comment on your patches: Be careful with their formatting, 
there's a couple of places where you mix tabs and spaces for their indenting 
while you probably wanted to use only spaces.

That was rather on the nitpick level, now let's move on a more fundamental 
level.

I can't really comment on the Dolphin's patch, that'd be more Peter's role.

Now on the KFilePlacesModel patch, I think I need some more information on 
your approach. I somehow doubt that a new accessibilityChanged() signal is 
needed there, as the intent was to have dataChanged() cover that (it's 
supposed to be emitted when the accessibility of the device indeed changes). 
In turn that'd mean that on the Dolphin side connecting to dataChanged() would 
be enough as well.

Regards.
-- 
Kévin Ottens, http://ervin.ipsquad.net

KDAB - proud patron of KDE, http://www.kdab.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100104/91a5bdc7/attachment.sig>