Review Request: KTextEdit should honor System Settings "Automatic spell checking" setting

[Christoph Feck]

> On 2010-02-24 22:53:10, Christoph Feck wrote:
> > When you remove that line, then you are right that it always respects the value from the configuration file. But you also remove the ability for the programmer to change that value by using the "setCheckSpellingEnabled()" function, so I doubt the patch is correct in the current form.
> 
> Anne-Marie Mahfouf wrote:
>     This code was introduced more than 5 years ago (before System Settings option which is why I refered to the commit) and then patched and patched to include various KSpell and Sonnet... Why would a programmer overwrite System Settings options nowadays? Is there a use case for this? Is the above function used somewhere? If yes, can you hint for a proper fix? Currently, the user global settings are ignored which I find pretty bad (and that was brought from a KNotes user who has all his notes with red underline at each start and found this very annoying).

How about removing http://lxr.kde.org/source/KDE/kdepim/knotes/knoteedit.cpp#55 then?

If you lxr for setCheckSpellingEnabled, you will see that in many places authors decided to enable spell checking (maybe because it was "off" by default in previous versions of KTextEdit). If you want that option to be user's choice, simply remove the calls there.

But there are places where it makes sense to enable spell checking automatically, such as in mails or bug report dialogs (anything that someone else might read), so I think it is not wise to kill this function (which is what your patch does).


- Christoph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3051/#review4272
-----------------------------------------------------------


On 2010-02-24 20:37:40, Anne-Marie Mahfouf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3051/
> -----------------------------------------------------------
> 
> (Updated 2010-02-24 20:37:40)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> When the user sets the Automatic Spell Checking enabled or not by default in System Settings, this should be propagated to KTextEdit. If I disabled automatic spell checking then all KTextEdit-based applications should respect this.
> This was intented in http://websvn.kde.org/?view=revision&revision=1002950 but the line I remove prevented it to work properly.
> 
> 
> Diffs
> -----
> 
>   branches/KDE/4.4/kdelibs/kdeui/widgets/ktextedit.cpp 1095665 
> 
> Diff: http://reviewboard.kde.org/r/3051/diff
> 
> 
> Testing
> -------
> 
> I tested with KNotes and the Notes applet and my fix works. 
> 
> 
> Thanks,
> 
> Anne-Marie
> 
>