Review Request: Automatic AdBlock filter list updates in Konqueror

Thomas Fischer fischer at
Sat Feb 6 21:08:38 GMT 2010

This is an automatically generated e-mail. To reply, visit:

(Updated 2010-02-06 21:08:38.775945)

Review request for kdelibs.


Addressing BIC issue. Now a private object takes care of signals&slots.
Open issue is proper configuration handling (both global/local configuration files and UI code e.g. for reset to defaults).


This is the patch from bug report 143495 slightly rewritten to fit KDE trunk (though not compiled as I am lacking Qt 4.6). The original patch was written for 4.2.4, later updated for 4.3.1. Please refer to the bug report in for a small history of this patch set.
I wrote a blog entry explaining the background of this patch, too:

Diffs (updated)

  /trunk/KDE/kdebase/apps/konqueror/settings/konqhtml/filteropts.h 1085993 
  /trunk/KDE/kdebase/apps/konqueror/settings/konqhtml/filteropts.cpp 1085993 
  /trunk/KDE/kdelibs/khtml/CMakeLists.txt 1086010 
  /trunk/KDE/kdelibs/khtml/khtml_settings.cpp 1086010 
  /trunk/KDE/kdelibs/khtml/khtmlrc PRE-CREATION 




Configuration dialog for automatic filter lists



More information about the kde-core-devel mailing list