Review Request: Automatic AdBlock filter list updates in Konqueror

[Thomas Fischer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2265/
-----------------------------------------------------------

(Updated 2010-02-05 07:24:26.032312)


Review request for kdelibs.


Changes
-------

Making some minor changes on KConfig usage


Summary
-------

This is the patch from bug report 143495 slightly rewritten to fit KDE trunk (though not compiled as I am lacking Qt 4.6). The original patch was written for 4.2.4, later updated for 4.3.1. Please refer to the bug report in bugs.kde.org for a small history of this patch set.
I wrote a blog entry explaining the background of this patch, too: http://blog.t-fischer.net/2009/08/05/automatic-adblock-filter-list-updates-in-konqueror/


Diffs (updated)
-----

  /trunk/KDE/kdebase/apps/konqueror/settings/konqhtml/filteropts.h 1082172 
  /trunk/KDE/kdebase/apps/konqueror/settings/konqhtml/filteropts.cpp 1082172 
  /trunk/KDE/kdelibs/khtml/khtml_settings.h 1082152 
  /trunk/KDE/kdelibs/khtml/khtml_settings.cpp 1082152 

Diff: http://reviewboard.kde.org/r/2265/diff


Testing
-------


Screenshots
-----------

Configuration dialog for automatic filter lists
  http://reviewboard.kde.org/r/2265/s/302/


Thanks,

Thomas