Review Request: Use translated folder names for default values in kcm desktoppaths

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6177/#review9355
-----------------------------------------------------------


Well, the default values used in the code (QDesktopServices) are not actually translated.

[from QDesktopServices::storageLocation in QTDIR/src/gui/util/qdesktopservices_x11.cpp]

    case DocumentsLocation:
        path = QDir::homePath() + QLatin1String("/Documents");
       break;
    case PicturesLocation:
        path = QDir::homePath() + QLatin1String("/Pictures");
        break;
    case MusicLocation:
        path = QDir::homePath() + QLatin1String("/Music");
        break;

So your commit would make the "Default" button incorrect, it would not revert to the defaults, i.e. to things as they were before the user made any changes.
Rejected, IMHO.

The technically correct way to reset to defaults would be on X11 to delete the relevant lines from ${XDG_CONFIG_HOME:~/.config}/user-dirs.dirs and call QDesktopServices again, but this wouldn't fix your problem anyway (untranslated defaults) and we'd need code for other platforms too.

- David


On 2010-12-21 14:18:35, Burkhard Lück wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6177/
> -----------------------------------------------------------
> 
> (Updated 2010-12-21 14:18:35)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Summary
> -------
> 
> Using the Defaults button in the desktoppaths kcm resets all folders to the default values, 
> but is currently using the untranslated strings in branch and trunk.
> 
> Adding some i18n() calls resets the values to the translated strings for the folders.
> 
> 
> Diffs
> -----
> 
>   /branches/KDE/4.5/kdebase/workspace/kcontrol/desktoppaths/globalpaths.cpp 1208322 
> 
> Diff: http://svn.reviewboard.kde.org/r/6177/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Burkhard
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20101221/1b5ef1f8/attachment.htm>