<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6177/">http://svn.reviewboard.kde.org/r/6177/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well, the default values used in the code (QDesktopServices) are not actually translated.
[from QDesktopServices::storageLocation in QTDIR/src/gui/util/qdesktopservices_x11.cpp]
case DocumentsLocation:
path = QDir::homePath() + QLatin1String("/Documents");
break;
case PicturesLocation:
path = QDir::homePath() + QLatin1String("/Pictures");
break;
case MusicLocation:
path = QDir::homePath() + QLatin1String("/Music");
break;
So your commit would make the "Default" button incorrect, it would not revert to the defaults, i.e. to things as they were before the user made any changes.
Rejected, IMHO.
The technically correct way to reset to defaults would be on X11 to delete the relevant lines from ${XDG_CONFIG_HOME:~/.config}/user-dirs.dirs and call QDesktopServices again, but this wouldn't fix your problem anyway (untranslated defaults) and we'd need code for other platforms too.</pre>
<br />
<p>- David</p>
<br />
<p>On December 21st, 2010, 2:18 p.m., Burkhard Lück wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs and David Faure.</div>
<div>By Burkhard Lück.</div>
<p style="color: grey;"><i>Updated 2010-12-21 14:18:35</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Using the Defaults button in the desktoppaths kcm resets all folders to the default values,
but is currently using the untranslated strings in branch and trunk.
Adding some i18n() calls resets the values to the translated strings for the folders.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/KDE/4.5/kdebase/workspace/kcontrol/desktoppaths/globalpaths.cpp <span style="color: grey">(1208322)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6177/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>