Review Request: Adjust the kde "fake" mimetype fonts/package so desktop-file-utils/shared-mime-info do not complain

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6111/#review9258
-----------------------------------------------------------


OK for the renaming, this is indeed about files.
Of course if foo.fonts.zip files exist outside of KDE, then this mimetype should also be requested in shared-mime-info.

You forgot something very important: to adjust the C++ code too.

kdebase/workspace/kcontrol/kfontinst/kcmfontinst/FontList.cpp: 1963:                mime->is("fonts/package") ||
kdebase/workspace/kcontrol/kfontinst/kcmfontinst/KCmFontInst.cpp: 481:                    "fonts/package");

and some comments (check that the code says...) :

kdebase/workspace/kcontrol/kfontinst/viewpart/FontViewPart.cpp: 278:         // Is this a fonts/package file? If so, extract 1 scalable font...
kdebase/workspace/kcontrol/kfontinst/thumbnail/FontThumbnail.cpp: 66:     // Is this a fonts/package file? If so, extract 1 scalable font...



/trunk/KDE/kdelibs/mimetypes/kde.xml
<http://svn.reviewboard.kde.org/r/6111/#comment10138>

    The comment is invalid now with the renaming, please move or remove it ;)


- David


On 2010-12-13 17:07:48, Rex Dieter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6111/
> -----------------------------------------------------------
> 
> (Updated 2010-12-13 17:07:48)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> This patch adjusts the kde "fake" mimetype fonts/package so desktop-file-utils/shared-mime-info doesn't complain (using application/vnd.kde.fontspackage instead).  Addresses bugs #235564, #250924
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/kcontrol/kfontinst/apps/kfontview.desktop 1206154 
>   /trunk/KDE/kdelibs/mimetypes/kde.xml 1206154 
> 
> Diff: http://svn.reviewboard.kde.org/r/6111/diff
> 
> 
> Testing
> -------
> 
> confirmed no warnings/errors from desktop-file-utils/shared-mime-info
> 
> 
> Thanks,
> 
> Rex
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20101215/a15a5a80/attachment.htm>