<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6111/">http://svn.reviewboard.kde.org/r/6111/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">OK for the renaming, this is indeed about files.
Of course if foo.fonts.zip files exist outside of KDE, then this mimetype should also be requested in shared-mime-info.
You forgot something very important: to adjust the C++ code too.
kdebase/workspace/kcontrol/kfontinst/kcmfontinst/FontList.cpp: 1963: mime->is("fonts/package") ||
kdebase/workspace/kcontrol/kfontinst/kcmfontinst/KCmFontInst.cpp: 481: "fonts/package");
and some comments (check that the code says...) :
kdebase/workspace/kcontrol/kfontinst/viewpart/FontViewPart.cpp: 278: // Is this a fonts/package file? If so, extract 1 scalable font...
kdebase/workspace/kcontrol/kfontinst/thumbnail/FontThumbnail.cpp: 66: // Is this a fonts/package file? If so, extract 1 scalable font...
</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://svn.reviewboard.kde.org/r/6111/diff/2/?file=42529#file42529line201" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/KDE/kdelibs/mimetypes/kde.xml</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">201</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c"><!-- fonts/ fake mime types --></span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">201</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c"><!-- fonts/ fake mime types --></span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The comment is invalid now with the renaming, please move or remove it ;)</pre>
</div>
<br />
<p>- David</p>
<br />
<p>On December 13th, 2010, 5:07 p.m., Rex Dieter wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Rex Dieter.</div>
<p style="color: grey;"><i>Updated 2010-12-13 17:07:48</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adjusts the kde "fake" mimetype fonts/package so desktop-file-utils/shared-mime-info doesn't complain (using application/vnd.kde.fontspackage instead). Addresses bugs #235564, #250924</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">confirmed no warnings/errors from desktop-file-utils/shared-mime-info</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdebase/workspace/kcontrol/kfontinst/apps/kfontview.desktop <span style="color: grey">(1206154)</span></li>
<li>/trunk/KDE/kdelibs/mimetypes/kde.xml <span style="color: grey">(1206154)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6111/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>