Review Request: In System Settings in French the icon's description is badly cut when there is a single quote

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6106/#review9226
-----------------------------------------------------------

Ship it!


A new unittest for a string handling method == great!

It's amusing to see that KWordWrap went through all this already (but since it's based on font metrics, the logic is a little bit different)

- David


On 2010-12-12 18:19:02, Anne-Marie Mahfouf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6106/
> -----------------------------------------------------------
> 
> (Updated 2010-12-12 18:19:02)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Patch to address https://bugs.kde.org/show_bug.cgi?id=257988: in French in System Settings the icon's description string is badly cut when there is a single quote. 
> Unit tests added for the whole method (by Fredrikh) and for the specific single quote by me.
> 
> Should go in 4.6 so please any kde-core devel review! Thanks
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/kdecore/tests/kstringhandlertest.h 1205827 
>   trunk/KDE/kdelibs/kdecore/tests/kstringhandlertest.cpp 1205827 
>   trunk/KDE/kdelibs/kdecore/text/kstringhandler.cpp 1205827 
> 
> Diff: http://svn.reviewboard.kde.org/r/6106/diff
> 
> 
> Testing
> -------
> 
> Tested in French, fixes the bug.
> 
> 
> Thanks,
> 
> Anne-Marie
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20101213/ebd5d992/attachment.htm>