Review Request: In System Settings in French the icon's description is badly cut when there is a single quote

Anne-Marie Mahfouf annma at kde.org
Sun Dec 12 18:19:02 GMT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6106/
-----------------------------------------------------------

Review request for kdelibs.


Summary
-------

Patch to address https://bugs.kde.org/show_bug.cgi?id=257988: in French in System Settings the icon's description string is badly cut when there is a single quote. 
Unit tests added for the whole method (by Fredrikh) and for the specific single quote by me.

Should go in 4.6 so please any kde-core devel review! Thanks


Diffs
-----

  trunk/KDE/kdelibs/kdecore/tests/kstringhandlertest.h 1205827 
  trunk/KDE/kdelibs/kdecore/tests/kstringhandlertest.cpp 1205827 
  trunk/KDE/kdelibs/kdecore/text/kstringhandler.cpp 1205827 

Diff: http://svn.reviewboard.kde.org/r/6106/diff


Testing
-------

Tested in French, fixes the bug.


Thanks,

Anne-Marie

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20101212/4ec0c12a/attachment.htm>


More information about the kde-core-devel mailing list