Review Request: Avoid different accesskeys for same target URL

[Rolf Eike Beer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5134/
-----------------------------------------------------------

(Updated 2010-08-29 08:31:26.339831)


Review request for kdelibs.


Changes
-------

As Lubos pointed out the first iteration was screwed up as I used the text instead of the URL as it was meant to be. Fixed that.


Summary
-------

The idea of this patch is to store all those URLs in a map that already have an accesskey assigned. If we find that URL later again the same accesskey is reused. Currently a new one is assigned so one would run out of accesskeys needlessly early on sites with many links of which some are duplicates.


This addresses bug 122356.
    https://bugs.kde.org/show_bug.cgi?id=122356


Diffs (updated)
-----

  trunk/KDE/kdelibs/khtml/khtmlview.cpp 1168440 

Diff: http://reviewboard.kde.org/r/5134/diff


Testing
-------

Compile tested only a while ago. Kdelibs currently breaks for me.


Thanks,

Rolf Eike

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100829/4a8af58e/attachment.htm>