Review Request: Avoid different accesskeys for same target URL

Rolf Eike Beer kde at
Sun Aug 29 09:31:28 BST 2010

This is an automatically generated e-mail. To reply, visit:

(Updated 2010-08-29 08:31:26.339831)

Review request for kdelibs.


As Lubos pointed out the first iteration was screwed up as I used the text instead of the URL as it was meant to be. Fixed that.


The idea of this patch is to store all those URLs in a map that already have an accesskey assigned. If we find that URL later again the same accesskey is reused. Currently a new one is assigned so one would run out of accesskeys needlessly early on sites with many links of which some are duplicates.

This addresses bug 122356.

Diffs (updated)

  trunk/KDE/kdelibs/khtml/khtmlview.cpp 1168440 



Compile tested only a while ago. Kdelibs currently breaks for me.


Rolf Eike

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list