Review Request: Avoid different accesskeys for same target URL

[Rolf Eike Beer]

> On 2010-08-27 10:22:08, Lubos Lunak wrote:
> > Why is the identity check using the link text and not url?

Brain bug.


- Rolf Eike


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5134/#review7240
-----------------------------------------------------------


On 2010-08-26 18:28:59, Rolf Eike Beer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5134/
> -----------------------------------------------------------
> 
> (Updated 2010-08-26 18:28:59)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> The idea of this patch is to store all those URLs in a map that already have an accesskey assigned. If we find that URL later again the same accesskey is reused. Currently a new one is assigned so one would run out of accesskeys needlessly early on sites with many links of which some are duplicates.
> 
> 
> This addresses bug 122356.
>     https://bugs.kde.org/show_bug.cgi?id=122356
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/khtml/khtmlview.cpp 1167171 
> 
> Diff: http://reviewboard.kde.org/r/5134/diff
> 
> 
> Testing
> -------
> 
> Compile tested only a while ago. Kdelibs currently breaks for me.
> 
> 
> Thanks,
> 
> Rolf Eike
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100829/2d048aa1/attachment.htm>