Review Request: Move Konqueror throbber from menubar to the toolbar

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4743/#review7160
-----------------------------------------------------------

Ship it!


Adam Treat (who moved the throbber to the menubar) said OK.
>From my own point of view, I'm happy to get rid of the icon size hacks in the current code, they never really worked. Please commit.

- David


On 2010-08-18 11:12:25, Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4743/
> -----------------------------------------------------------
> 
> (Updated 2010-08-18 11:12:25)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Summary
> -------
> 
> Konqueror shows its throbber in the right corner of its menubar. This is a problem for the "application menu" project I am working on (see http://wiki.ubuntu.com/DesktopExperienceTeam/ApplicationMenu ): custom widgets can't go through DBus.
> 
> Attached patch moves it to the toolbar. If there is interest, I could improve on it so that it does not display a button frame when the mouse is moved over it, since clicking it does not trigger any action (this was already the case when it was in the menubar).
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/apps/konqueror/src/konqanimatedlogo.cpp 1147944 
>   trunk/KDE/kdebase/apps/konqueror/src/konqanimatedlogo_p.h 1147944 
>   trunk/KDE/kdebase/apps/konqueror/src/konqmainwindow.cpp 1147944 
>   trunk/KDE/kdebase/apps/konqueror/src/konqueror.rc 1147944 
> 
> Diff: http://reviewboard.kde.org/r/4743/diff
> 
> 
> Testing
> -------
> 
> - Tested in still and loading mode.
> - Verified the throbber resizes itself when the toolbar icon size is changed.
> 
> 
> Thanks,
> 
> Aurélien
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100823/18127005/attachment.htm>