Review Request: Move Konqueror throbber from menubar to the toolbar

Aurélien Gâteau agateau at
Wed Aug 18 12:12:25 BST 2010

This is an automatically generated e-mail. To reply, visit:

(Updated 2010-08-18 11:12:25.238733)

Review request for kdelibs and David Faure.


Added the missing <Merge/> element in konqueror.rc


Konqueror shows its throbber in the right corner of its menubar. This is a problem for the "application menu" project I am working on (see ): custom widgets can't go through DBus.

Attached patch moves it to the toolbar. If there is interest, I could improve on it so that it does not display a button frame when the mouse is moved over it, since clicking it does not trigger any action (this was already the case when it was in the menubar).

Diffs (updated)

  trunk/KDE/kdebase/apps/konqueror/src/konqanimatedlogo.cpp 1147944 
  trunk/KDE/kdebase/apps/konqueror/src/konqanimatedlogo_p.h 1147944 
  trunk/KDE/kdebase/apps/konqueror/src/konqmainwindow.cpp 1147944 
  trunk/KDE/kdebase/apps/konqueror/src/konqueror.rc 1147944 



- Tested in still and loading mode.
- Verified the throbber resizes itself when the toolbar icon size is changed.



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list