Review Request: Add option to KGlobalConfig::activate() to skip connection to dbus

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5072/#review7137
-----------------------------------------------------------



trunk/KDE/kdelibs/kdeui/kernel/kglobalsettings.h
<http://reviewboard.kde.org/r/5072/#comment7276>

    Maybe this could be turned around positively to avoid Dont.. flags?
    
    ApplySettings = 1,
    ListenForChanges = 2,
    ActivateAll = ApplySettings | ListenForChanges
    
    Although maybe not having ActivateAll is a better idea; if we add a new optional feature then it would not be part of the value for ActivateAll (which cannot change for BC reasons). So I would suggest having just 1 and 2, and calling with both in the old activate().
    
    [If we want to add an opt-out feature then it's difficult whichever solution we choose, we'd have to use a Dont flag at that point anyway].


- David


On 2010-08-19 14:00:53, George Kiagiadakis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5072/
> -----------------------------------------------------------
> 
> (Updated 2010-08-19 14:00:53)
> 
> 
> Review request for kdelibs, David Faure and Oswald Buddenhagen.
> 
> 
> Summary
> -------
> 
> This patch modifies KGlobalConfig so that it is possible for applications to tell it not to connect to dbus and listen for configuration changes from other applications. This is useful for kdm, because if QDBusConnection::sessionBus() is called while there is no session bus running, a new session bus is automatically created, which makes no sense for kdm.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/kdeui/kernel/kglobalsettings.h 1165324 
>   trunk/KDE/kdelibs/kdeui/kernel/kglobalsettings.cpp 1165324 
> 
> Diff: http://reviewboard.kde.org/r/5072/diff
> 
> 
> Testing
> -------
> 
> Tested with kdm after modifying its call to activate() to use the DontListenForChanges flag. kdm no longer starts a dbus session.
> 
> 
> Thanks,
> 
> George
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100819/0f1a1f07/attachment.htm>