<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/5072/">http://reviewboard.kde.org/r/5072/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="/r/5072/diff/1/?file=34225#file34225line554" style="color: black; font-weight: bold; text-decoration: underline;">trunk/KDE/kdelibs/kdeui/kernel/kglobalsettings.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">554</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">Q_DECLARE_FLAGS</span><span class="p">(</span><span class="n">ActivateOptions</span><span class="p">,</span> <span class="n">ActivateOption</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Maybe this could be turned around positively to avoid Dont.. flags?
ApplySettings = 1,
ListenForChanges = 2,
ActivateAll = ApplySettings | ListenForChanges
Although maybe not having ActivateAll is a better idea; if we add a new optional feature then it would not be part of the value for ActivateAll (which cannot change for BC reasons). So I would suggest having just 1 and 2, and calling with both in the old activate().
[If we want to add an opt-out feature then it's difficult whichever solution we choose, we'd have to use a Dont flag at that point anyway].</pre>
</div>
<br />
<p>- David</p>
<br />
<p>On August 19th, 2010, 2 p.m., George Kiagiadakis wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs, David Faure and Oswald Buddenhagen.</div>
<div>By George Kiagiadakis.</div>
<p style="color: grey;"><i>Updated 2010-08-19 14:00:53</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch modifies KGlobalConfig so that it is possible for applications to tell it not to connect to dbus and listen for configuration changes from other applications. This is useful for kdm, because if QDBusConnection::sessionBus() is called while there is no session bus running, a new session bus is automatically created, which makes no sense for kdm.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with kdm after modifying its call to activate() to use the DontListenForChanges flag. kdm no longer starts a dbus session.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdelibs/kdeui/kernel/kglobalsettings.h <span style="color: grey">(1165324)</span></li>
<li>trunk/KDE/kdelibs/kdeui/kernel/kglobalsettings.cpp <span style="color: grey">(1165324)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/5072/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>