Review Request: delete some unneded if(not null)

[Sjors Gielen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5021/#review7052
-----------------------------------------------------------



/trunk/KDE/kdelibs/kdecore/localization/probers/nsUniversalDetector.cpp
<http://reviewboard.kde.org/r/5021/#comment7118>

    I think you missed one here? :)
    
    Good patch, though. :)


- Sjors


On 2010-08-14 08:55:05, Jaime Torres wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5021/
> -----------------------------------------------------------
> 
> (Updated 2010-08-14 08:55:05)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> delete handles null pointers fine in c++
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/dnssd/mdnsd-responder.cpp 1163215 
>   /trunk/KDE/kdelibs/kate/syntax/katesyntaxdocument.cpp 1163215 
>   /trunk/KDE/kdelibs/kde3support/kdeui/k3dockwidget_private.cpp 1163215 
>   /trunk/KDE/kdelibs/kdecore/date/ktimezone.cpp 1163215 
>   /trunk/KDE/kdelibs/kdecore/kernel/kcmdlineargs.cpp 1163215 
>   /trunk/KDE/kdelibs/kdecore/localization/guess_ja_p.h 1163215 
>   /trunk/KDE/kdelibs/kdecore/localization/probers/nsUniversalDetector.cpp 1163215 
>   /trunk/KDE/kdelibs/kdeui/kernel/kapplication.cpp 1163215 
>   /trunk/KDE/kdelibs/kdeui/tests/kcomboboxtest.cpp 1163215 
>   /trunk/KDE/kdelibs/kdeui/tests/ktabwidgettest.cpp 1163215 
>   /trunk/KDE/kdelibs/kdeui/widgets/kled.cpp 1163215 
>   /trunk/KDE/kdelibs/kio/kssl/ksslpkcs12.cpp 1163215 
>   /trunk/KDE/kdelibs/kio/kssl/ksslpkcs7.cpp 1163215 
>   /trunk/KDE/kdelibs/kio/misc/ksendbugmail/smtp.cpp 1163215 
>   /trunk/KDE/kdelibs/kioslave/http/http.cpp 1163215 
>   /trunk/KDE/kdelibs/plasma/abstractrunner.cpp 1163215 
>   /trunk/KDE/kdelibs/plasma/containment.cpp 1163215 
>   /trunk/KDE/kdelibs/plasma/packagestructure.cpp 1163215 
>   /trunk/KDE/kdelibs/plasma/service.cpp 1163215 
> 
> Diff: http://reviewboard.kde.org/r/5021/diff
> 
> 
> Testing
> -------
> 
> working with it.
> 
> 
> Thanks,
> 
> Jaime
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100814/3b4134b3/attachment.htm>