<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/5021/">http://reviewboard.kde.org/r/5021/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="/r/5021/diff/1/?file=33808#file33808line55" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/KDE/kdelibs/kdecore/localization/probers/nsUniversalDetector.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">nsUniversalDetector::~nsUniversalDetector()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">55</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">mCharSetProbers</span><span class="p">[</span><span class="n">i</span><span class="p">])</span><span class="ew"> </span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">55</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">mCharSetProbers</span><span class="p">[</span><span class="n">i</span><span class="p">])</span><span class="ew"> </span></pre></td>
</tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">56</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">delete</span> <span class="n">mCharSetProbers</span><span class="p">[</span><span class="n">i</span><span class="p">];</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">56</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">delete</span> <span class="n">mCharSetProbers</span><span class="p">[</span><span class="n">i</span><span class="p">];</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think you missed one here? :)
Good patch, though. :)</pre>
</div>
<br />
<p>- Sjors</p>
<br />
<p>On August 14th, 2010, 8:55 a.m., Jaime Torres wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Jaime Torres.</div>
<p style="color: grey;"><i>Updated 2010-08-14 08:55:05</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">delete handles null pointers fine in c++</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">working with it.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdelibs/dnssd/mdnsd-responder.cpp <span style="color: grey">(1163215)</span></li>
<li>/trunk/KDE/kdelibs/kate/syntax/katesyntaxdocument.cpp <span style="color: grey">(1163215)</span></li>
<li>/trunk/KDE/kdelibs/kde3support/kdeui/k3dockwidget_private.cpp <span style="color: grey">(1163215)</span></li>
<li>/trunk/KDE/kdelibs/kdecore/date/ktimezone.cpp <span style="color: grey">(1163215)</span></li>
<li>/trunk/KDE/kdelibs/kdecore/kernel/kcmdlineargs.cpp <span style="color: grey">(1163215)</span></li>
<li>/trunk/KDE/kdelibs/kdecore/localization/guess_ja_p.h <span style="color: grey">(1163215)</span></li>
<li>/trunk/KDE/kdelibs/kdecore/localization/probers/nsUniversalDetector.cpp <span style="color: grey">(1163215)</span></li>
<li>/trunk/KDE/kdelibs/kdeui/kernel/kapplication.cpp <span style="color: grey">(1163215)</span></li>
<li>/trunk/KDE/kdelibs/kdeui/tests/kcomboboxtest.cpp <span style="color: grey">(1163215)</span></li>
<li>/trunk/KDE/kdelibs/kdeui/tests/ktabwidgettest.cpp <span style="color: grey">(1163215)</span></li>
<li>/trunk/KDE/kdelibs/kdeui/widgets/kled.cpp <span style="color: grey">(1163215)</span></li>
<li>/trunk/KDE/kdelibs/kio/kssl/ksslpkcs12.cpp <span style="color: grey">(1163215)</span></li>
<li>/trunk/KDE/kdelibs/kio/kssl/ksslpkcs7.cpp <span style="color: grey">(1163215)</span></li>
<li>/trunk/KDE/kdelibs/kio/misc/ksendbugmail/smtp.cpp <span style="color: grey">(1163215)</span></li>
<li>/trunk/KDE/kdelibs/kioslave/http/http.cpp <span style="color: grey">(1163215)</span></li>
<li>/trunk/KDE/kdelibs/plasma/abstractrunner.cpp <span style="color: grey">(1163215)</span></li>
<li>/trunk/KDE/kdelibs/plasma/containment.cpp <span style="color: grey">(1163215)</span></li>
<li>/trunk/KDE/kdelibs/plasma/packagestructure.cpp <span style="color: grey">(1163215)</span></li>
<li>/trunk/KDE/kdelibs/plasma/service.cpp <span style="color: grey">(1163215)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/5021/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>