Review Request: New method KUrl::List::toStringList(KUrl::AdjustPathOption)

Sebastian Trueg trueg at
Tue Aug 10 10:13:30 BST 2010

This is an automatically generated e-mail. To reply, visit:

(Updated 2010-08-10 09:13:29.496336)

Review request for kdelibs and David Faure.


Before I commit this I would like to fix this issue in the test: apparently KUrl("").url(RemoveTrailingSlash) == "ftp:///" which is weird since path(RemoveTrailingSlash) returns "/" and KUrl("").url(RemoveTrailingSlash) == "ftp:///".
Once this is resolved I will commit the patch.


In the Nepomuk query API I need to convert a list of KUrls into strings, each with a trailing slash. Instead of adding my own code which clutters kdelibs and makes it less readable I did the obvious and added the KUrl::AdjustPathOption parameter to KUrl::List::toStringList which internally uses KUrl::url to convert urls to strings. The latter uses the same parameter. Thus, IMHO it is only natural to expose it in toStringList, too.

Diffs (updated)

  trunk/KDE/kdelibs/kdecore/io/kurl.h 1159053 
  trunk/KDE/kdelibs/kdecore/io/kurl.cpp 1159053 
  trunk/KDE/kdelibs/kdecore/tests/kurltest.h 1159053 
  trunk/KDE/kdelibs/kdecore/tests/kurltest.cpp 1159053 





-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list