Review Request: New method KUrl::List::toStringList(KUrl::AdjustPathOption)

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4896/#review6897
-----------------------------------------------------------

Ship it!


Looks ok, although it misses a unittest addition to look perfect.

- David


On 2010-08-04 09:00:53, Sebastian Trueg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4896/
> -----------------------------------------------------------
> 
> (Updated 2010-08-04 09:00:53)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Summary
> -------
> 
> In the Nepomuk query API I need to convert a list of KUrls into strings, each with a trailing slash. Instead of adding my own code which clutters kdelibs and makes it less readable I did the obvious and added the KUrl::AdjustPathOption parameter to KUrl::List::toStringList which internally uses KUrl::url to convert urls to strings. The latter uses the same parameter. Thus, IMHO it is only natural to expose it in toStringList, too.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/kdecore/io/kurl.h 1159053 
>   trunk/KDE/kdelibs/kdecore/io/kurl.cpp 1159053 
> 
> Diff: http://reviewboard.kde.org/r/4896/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sebastian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100809/94d28595/attachment.htm>