kdelibs win x64 patches
Diego Iastrubni
elcuco at kde.org
Tue Apr 27 20:27:44 BST 2010
Hi Ralf,
I am not a win32 guru, so two small things:
Isn't it "too ugly"? Why keeping this code? How about an "#if 0", or something
similar?
>--- kio/kio/global.h (Revision 1118962)
>+++ kio/kio/global.h (Arbeitskopie)
>@@ -35,9 +35,9 @@
>
> #include <kjob.h>>-#ifdef Q_OS_WIN
>-template class KDE_EXPORT QMap<QString, QString>;
>-#endif
>+//#ifdef Q_OS_WIN
>+//template class KDE_EXPORT QMap<QString, QString>;
>+//#endif
WOW. Including windows.h ... ? Isn't this file a little big? Not everyone has
PCH enabled and working.
>+++ kio/kssl/kopenssl.h (Arbeitskopie)
>@@ -30,6 +30,9 @@
> #include <ksslconfig.h>
>
> #ifdef KSSL_HAVE_SSL
>+#ifdef Q_WS_WIN
>+#include <windows.h>
>+#endif
On יום שני 26 אפריל 2010 14:37:14 Ralf Habacker wrote:
> Hi,
>
> Patrick von Reth sent me patches for compiling kdelibs with x64 mingw
> compiler. They mostly covers "loss presision" errors by using
> (u)intptr_t types instead of (unsigned)long
>
> Are there any problems with this patches ? Otherwise I would commit them
> into kdelibs svn trunk
>
> Regards
> Ralf
More information about the kde-core-devel
mailing list