Review Request: Fix loss of formatting when removing a link from a KRichTextEdit derived editor.

[Jason Jackson]

> On 2010-04-23 22:49:34, Raphael Kubo da Costa wrote:
> > /trunk/KDE/kdelibs/kdeui/tests/krichtextedittest.cpp, line 114
> > <http://reviewboard.kde.org/r/3609/diff/3/?file=24236#file24236line114>
> >
> >     Maybe it makes sense to change the link's color and check if it's still set as well?

I am not certain what this means. Could you elaborate?


- Jason


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3609/#review5196
-----------------------------------------------------------


On 2010-04-22 10:32:10, Jason Jackson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3609/
> -----------------------------------------------------------
> 
> (Updated 2010-04-22 10:32:10)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> KRichTextEdit derived editors would remove all formatting when a link was removed from the text, not just the link related formatting. This patch allows the text to retain its non-link related formatting, and also cleans up the overall KRichTextEdit::updateLink method to make the logic a little simpler.
> 
> 
> This addresses bug 234439.
>     https://bugs.kde.org/show_bug.cgi?id=234439
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdeui/tests/krichtextedittest.cpp 1116838 
>   /trunk/KDE/kdelibs/kdeui/tests/krichtextedittest.h 1116838 
>   /trunk/KDE/kdelibs/kdeui/widgets/krichtextedit.cpp 1116838 
> 
> Diff: http://reviewboard.kde.org/r/3609/diff
> 
> 
> Testing
> -------
> 
> Made a test case with a KRichTextEdit component to ensure the behavior was as expected.
> 
> 
> Thanks,
> 
> Jason
> 
>