Review Request: Fix loss of formatting when removing a link from a KRichTextEdit derived editor.
Raphael Kubo da Costa
kubito at gmail.com
Fri Apr 23 23:49:30 BST 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3609/#review5196
-----------------------------------------------------------
/trunk/KDE/kdelibs/kdeui/tests/krichtextedittest.cpp
<http://reviewboard.kde.org/r/3609/#comment4690>
Duplicated line.
/trunk/KDE/kdelibs/kdeui/tests/krichtextedittest.cpp
<http://reviewboard.kde.org/r/3609/#comment4691>
Maybe it makes sense to change the link's color and check if it's still set as well?
- Raphael
On 2010-04-22 10:32:10, Jason Jackson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3609/
> -----------------------------------------------------------
>
> (Updated 2010-04-22 10:32:10)
>
>
> Review request for kdelibs.
>
>
> Summary
> -------
>
> KRichTextEdit derived editors would remove all formatting when a link was removed from the text, not just the link related formatting. This patch allows the text to retain its non-link related formatting, and also cleans up the overall KRichTextEdit::updateLink method to make the logic a little simpler.
>
>
> This addresses bug 234439.
> https://bugs.kde.org/show_bug.cgi?id=234439
>
>
> Diffs
> -----
>
> /trunk/KDE/kdelibs/kdeui/tests/krichtextedittest.cpp 1116838
> /trunk/KDE/kdelibs/kdeui/tests/krichtextedittest.h 1116838
> /trunk/KDE/kdelibs/kdeui/widgets/krichtextedit.cpp 1116838
>
> Diff: http://reviewboard.kde.org/r/3609/diff
>
>
> Testing
> -------
>
> Made a test case with a KRichTextEdit component to ensure the behavior was as expected.
>
>
> Thanks,
>
> Jason
>
>
More information about the kde-core-devel
mailing list