activities api in kdereview
trueg at kde.org
Tue Apr 20 19:26:07 BST 2010
sorry, I had a problem with svn and did not find the service before.
Some small comments (not urgent)
- Please use the query API instead of hardcoded SPARQL strings.
- Instead of ACTIVITIES_QUERY you can use
- Better do not use toString on URLs. You will loose accuracy with many
file URLs. Use KUrl and KUrl::url() instead.
And then a note about the class documentation: way too little. You
should at least explain what activities are and if possible link between
the different classes.
On 04/20/2010 05:49 PM, Ivan Čukić wrote:
> All previously reported issues fixed - i18n, Q_PROPERTIES and APIDOX
> Anything else?
> Just as a reminder, KActivityConsumer is intended for kdelibs, while other two
> client classes, since we don't want to guarantee API and ABI compatibility at
> the moment are for kdebase. KActivityInfo is intended to be moved to kdelibs
> later (after 4.5).
More information about the kde-core-devel