Review Request: Add "QString iconName()" method to KIcon
Aurélien Gâteau
agateau at kde.org
Tue Apr 13 15:04:10 BST 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3585/
-----------------------------------------------------------
Review request for kdelibs, Marco Martin and Hamish Rodda.
Summary
-------
This patch is a necessary step for dbusmenu [1]: To be able to export a menu over dbus, we need to know the name of the icons, thus the need for a "QString KIcon::iconName()" method.
As you can see in the code comment, I am not really happy with the way it is implemented, but do not see any other way.
[1] http://people.canonical.com/~agateau/dbusmenu/
Diffs
-----
trunk/KDE/kdelibs/kdeui/icons/kicon.h 1114121
trunk/KDE/kdelibs/kdeui/icons/kicon.cpp 1114121
Diff: http://reviewboard.kde.org/r/3585/diff
Testing
-------
Thanks,
Aurélien
More information about the kde-core-devel
mailing list