Review Request: Make KHTMLFindBar look like Okular's findbar

[Parker Coates]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3590/#review5009
-----------------------------------------------------------


Screenshots for the lazy?

- Parker


On 2010-04-13 16:00:29, Sascha Peilicke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3590/
> -----------------------------------------------------------
> 
> (Updated 2010-04-13 16:00:29)
> 
> 
> Review request for kdelibs and Bernhard Beschow.
> 
> 
> Summary
> -------
> 
> Currently Konsole, Okular and Konqi have differently looking findbars. This patch aligns KHTMLFindBar to look like Okular's findbar. 
> 
> This means the search input lineedit uses the maximum size and all toolbuttons are replaced with pushbuttons (they show icon and text anyway). This emphasises the search lineedit and makes the buttons look more visually pleasant IMHO. Furthermore the status label was removed, it displayed only a text which said that the search text wasn't found anymore. This info is already pleasant in the lineedit, it becomes red if nothing is found and green if there are more results available. This should be sufficient.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/khtml/ui/findbar/khtmlfindbar.cpp 1114392 
>   trunk/KDE/kdelibs/khtml/ui/findbar/khtmlfindbar_base.ui 1114392 
> 
> Diff: http://reviewboard.kde.org/r/3590/diff
> 
> 
> Testing
> -------
> 
> tested on r1113765, works.
> 
> 
> Thanks,
> 
> Sascha
> 
>