Review Request: fish kioslave fix

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3442/#review4976
-----------------------------------------------------------

Ship it!


Looks good to me.

- David


On 2010-03-30 03:06:45, Glen Kaukola wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3442/
> -----------------------------------------------------------
> 
> (Updated 2010-03-30 03:06:45)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> The fish kioslave was using the '.' character as the delimiter for username and
> group.  I switched it over to use ':' as the delimiter since that isn't a valid
> character for usernames or groups.
> 
> 
> This addresses bug 227678.
>     https://bugs.kde.org/show_bug.cgi?id=227678
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/runtime/kioslave/fish/fish.cpp 1108903 
>   /trunk/KDE/kdebase/runtime/kioslave/fish/fish.pl 1108903 
> 
> Diff: http://reviewboard.kde.org/r/3442/diff
> 
> 
> Testing
> -------
> 
> Created a j.black user and swdev group.  Files owned by that user and group displayed correctly in dolphin.
> 
> 
> Thanks,
> 
> Glen
> 
>