KInfoCenter rewrite in Kdereview

[David Hubner]

On Friday 09 April 2010 21:03:39 Albert Astals Cid wrote:
> A Divendres, 9 d'abril de 2010, David Hubner va escriure:
> > On Friday 09 April 2010 19:37:33 Albert Astals Cid wrote:
> > > A Divendres, 9 d'abril de 2010, David Hubner va escriure:
> > > > On Tuesday 06 April 2010 17:09:31 Albert Astals Cid wrote:
> > > > > A Dimarts, 6 d'abril de 2010, David Hubner va escriure:
> > > > > > Hi,
> > > > > > 
> > > > > > I have mostly finished the new rewrite of kinfocenter. The rewrite
> > > > > > was due to a lot of legacy code in the old version, it was going
> > > > > > to be more trouble to modify the old code than write new code.
> > > > > > 
> > > > > > Some new features of the kinfocenter are:
> > > > > > 
> > > > > > - Getting some consistency between system settings.
> > > > > > - Summary page
> > > > > > - removes all legacy code and uses model/view
> > > > > > - new summary KCM
> > > > > > - Better organisation of the KCM's
> > > > > > - Export
> > > > > > 
> > > > > > There is still a few things to do at the moment, i need to redo
> > > > > > some of the documentation as well as write new parts and add
> > > > > > Whatsthis information to the KCM's
> > > > > > 
> > > > > > Some things to take note are:
> > > > > > 
> > > > > > - The network interfaces viewer is not complete yet, it will appear
> > > > > > blank. - You need trunk due to patches added to solid and KdeUI
> > > > > > - Only summary has export functionality at the moment. It will be
> > > > > > added to most of them. - The tooltips need a little more info.
> > > > > > 
> > > > > > Apart from that i feel it is complete. If possible could i get some
> > > > > > feedback on what people think? Its in kdereview under kinfocenter2.
> > > > > 
> > > > > ./Modules/pci/kpci.cpp has some untranslatable strings in the form of
> > > > > QString("%1 MiB").arg(static_cast<unsigned long>(size/0x100000))
> > > > 
> > > > I shall fix this at some point but i am doing the KInfoCenter rewrite
> > > > in two stages, stage 1 being the rewrite of the kinfocenter client
> > > > before 4.5 and stage 2 is redoing some of the old KCM's before 4.6
> > > > 
> > > > Its been there since KDE2 so i think it can wait.. that said hopefully
> > > > i can get to it before 4.5 string freeze.
> > > 
> > > I'm not sure i agree here, it's a bug, should we let programs pass
> > > kdereview with known bugs moreover when it's very easy to fix bugs?
> > > 
> > > > > Your main Messages.sh extracts to something called kinfocenter2.pot
> > > > > but your program is still called kinfocenter in main.cpp
> > > > 
> > > > Fixed.
> > > > 
> > > > > The files in base/ do not get their messages extracted for
> > > > > translation. Seems it does not seem a real module you might want to
> > > > > add them to the main message catalog
> > > > 
> > > > Base does not have any translation to do, its just different OS
> > > > information parts.
> > > 
> > > ~/kdereview/kinfocenter2/Modules/base$ wcgrep "i18n(" | wc -l
> > > 189
> > > 
> > > I have 189 lines that seem to disagree with you.
> > > 
> > > Albert
> > 
> > DAMN YOU 189 LINES, DAMN YOU!!! :)
> > 
> > The base, info and memory KCM's need a bit of redoing, i shall add it to a
> > post it note and hopefully get it done before 4.5
> 
> Again i disagree, you are in kdereview to be reviewed and having around 200 
> messages that are untranslatable is big bug with my l10n hat on.
> 
> Albert
> 

Guess your right, i am just trying to get my post it note collection smaller :)
I have added Messages.sh to the base directory. Its used in 2-3 modules that shall soon be rewritten for 4.6 so its probably best that it is translated on its own and not added to the main message catalog. 

-- 
David Hubner
IRC: hubnerd
MSN: hubnerd at hubnerd.org
ICQ: 24308559