Kopete runner now in kdereview

[Ben Boeckel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Albert Astals Cid wrote:

> A Dijous, 24 de setembre de 2009, Ben Boeckel va escriure:
>> Hi,
>> 
>> I moved the Kopete runner I've been working on into kdereview
>> today (kopete-runner subdir). I fixed the last bug I was
>> experiencing with KRunner grabbing Kopete's config since the
>> name was set to be "kopete". In any case it supports:
>> 
>> With default identity:
>> - Connecting
>>   - connect
>> - Disconnecting
>>   - disconnect
>> - Setting status (with and without message)
>>   - status <status> [message]
>> - Setting status message
>>   - message <message>
>> - Starting chats
>>   - matches name used in buddy list
>> 
>> When matching buddies, it uses the buddy icon and also shows 
the
>> status and message (if any, currently broken in Kopete DBus
>> interface bko#204230).
>> 
>> Kopete's DBus interface could be improved to expose more
>> information (individual accounts, buddies in a metacontact,
>> screenname, etc.), but with what is available, this is all 
that
>> is possible.
>> 
>> I would like to see this in kdenetwork with Kopete itself, 
but
>> kdebase (everything is done over DBus, so no kdenetwork
>> dependency here) and kdeplasma-addons in extragear are also
>> options. Thanks for any feedback.
> 
> const QStringList& ids = m_contactData.keys();
> foreach (const QString& id, ids)
> {
> 	const ContactProperties& props = m_contactData[id];
> 
> 
> This is slower and uses more memory than it needs to, please 
use a regular 
> iterator to traverse m_contactData.
> 
> Albert
> 
> 
>> 
>> --Ben

Fixed in r1027707.

- --Ben
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iQIcBAEBCAAGBQJKu3qEAAoJEKaxavVX4C1XzQ4QAOf0JhR0r6gq9cxEzydx5RVi
9TQ6+dx9wpJxbxr7P0fi6NDH2Yrfbc9U6Qlx/fOaoS1fLL98Xnd2KEE5gPSX5rI0
oErxRW52SI+TQ0Do0sUvQAP1zQaGxc8WjFLzZHkkV9WGlRHSup+5KQeeZqTu7bBn
Hk3CDG74xlJhRhAV9eA07AofBWMSg/RtUvkOMnRzfx2f0Pvs9/zV1OKgwFItbGnk
DjieS7xTbKgICkEaTz+2bJJx2cLS4OMYNG9IDsTCr+6uFSYVZjhYqVZOeTiZtarJ
o5eb1J6Pv6xKO+B04Rhvog9Nfi90YO3XIb7Mq0RK/UHnp0ooku0Rfne82kUVxYw/
gpLtJqtCTWnLr8Tvc4ENqLFGseP/xVzQW72XNQGxRZR0ahzbUHu/0qkaUy0l/k7Y
ITEHzR99Yz3kC+CEhCqm9+kdB7KVomH1AOxvigRKjOy5MY7h50nxwz06VFjm3UnP
FdSvAVpi71gE85Y6R/wsPuPt0HaeFVHZThPOtbz3lxlg966SkEaggyZHZck0Iw+T
u/oTj6RrofwdkNA95EtWjZp6M8o/lWoD4yT2Nxku1mBWQ1rdjSJrvhnyB7scWXy2
hILt2nqMuCCrkdBQbiueONoHfre6LUULYgCGUUfJ8WX6ivsNOhjgS1dJWWcrAjJ1
ESo1kIsgsB6k6DUMY+Ud
=e6wF
-----END PGP SIGNATURE-----